Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 7, 2020

Removes the unused gesture code that was deprecated a while ago.

BREAKING CHANGES:

  • MAT_HAMMER_OPTIONS has been removed.
  • GestureConfig has been removed.
  • HammerInput has been removed.
  • HammerStatic has been removed.
  • Recognizer has been removed.
  • RecognizerStatic has been removed.
  • HammerInstance has been removed.
  • HammerManager has been removed.
  • HammerOptions has been removed.

Removes the unused gesture code that was deprecated a while ago.

BREAKING CHANGES:
* `MAT_HAMMER_OPTIONS` has been removed.
* `GestureConfig` has been removed.
* `HammerInput` has been removed.
* `HammerStatic` has been removed.
* `Recognizer` has been removed.
* `RecognizerStatic` has been removed.
* `HammerInstance` has been removed.
* `HammerManager` has been removed.
* `HammerOptions` has been removed.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 7, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner May 7, 2020 15:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 7, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 7, 2020
@crisbeto
Copy link
Member Author

crisbeto commented May 7, 2020

cc @devversion. I don't know whether we don't need to adjust the Hammer migration schematic as well.

@devversion
Copy link
Member

@devversion devversion added the lgtm label May 7, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 7, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 9e5fbd8 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants